Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Handle Send Errors for CLN #96

Closed
carlaKC opened this issue Sep 11, 2023 · 0 comments · Fixed by #104
Closed

Bug: Handle Send Errors for CLN #96

carlaKC opened this issue Sep 11, 2023 · 0 comments · Fixed by #104
Assignees
Labels
bug Something isn't working High Priority
Milestone

Comments

@carlaKC
Copy link
Contributor

carlaKC commented Sep 11, 2023

When CLN fails a payment (eg, because there's no route), they'll fail the entire API call rather than sending back an okay response containing an error code. This will shut down the simulation, so we'll need to add some error handling.

My instinct would be to take a look at the error code they're giving us (hopefully that helps classify pathfinding errors vs terminal errors).

ERROR [sim_lib] Error while sending payment 0366dc9e42d6cb2a89d3ba9a347a0995c88e62949618db6f62bd86fd1da0364868 
-> 02c0c6b8be1a367c2fce4efdd9ea075b1e2b15d2566c6eab845513a88e313ee0ab. 

Terminating consumer. Send payment error status: 
Unknown, message: "Error calling method KeySend: RpcError { 
code: Some(210), message: \"Ran out of routes to try after 1 attempt: see `paystatus`\" }", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Mon, 11 Sep 2023 15:48:33 GMT", "content-length": "0"} 
}
@carlaKC carlaKC added the bug Something isn't working label Sep 11, 2023
@okjodom okjodom self-assigned this Sep 15, 2023
@carlaKC carlaKC added this to the V1 milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working High Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants