feat: track payment on cln nodes #75
Conversation
okjodom
force-pushed
the
cln-track-payment
branch
from
256e64b to
0c9b464
Compare
okjodom
changed the title
sim-lib/src/cln.rs
Outdated
| } | ||
| } | ||
|
|
||
| time::sleep(Duration::from_millis(100)).await; |
There was a problem hiding this comment.
Can we also select on sleep + shutdown here? That lets us exit a little faster if we shut down while tracking the payment.
If we do this we can probably bump it up to polling once a second so that we don't hammer CLN too much.
There was a problem hiding this comment.
select kind of fun
There was a problem hiding this comment.
Aren't we sleeping twice now?
Feels like this sleep should be removed and the duration of the sleep in select should be reduced.
There was a problem hiding this comment.
Feels like this sleep should be removed and the duration of the sleep in select should be reduced.
Yeah, that's what I was thinking. If we have both in the select we'll exit when we need, otherwise wait so this line can be removed!
There was a problem hiding this comment.
fixed! I was inattentive
okjodom
force-pushed
the
cln-track-payment
branch
from
0c9b464 to
4b9dd98
Compare
sim-lib/src/cln.rs
Outdated
| } | ||
| } | ||
|
|
||
| time::sleep(Duration::from_millis(100)).await; |
There was a problem hiding this comment.
Aren't we sleeping twice now?
Feels like this sleep should be removed and the duration of the sleep in select should be reduced.
sim-lib/src/cln.rs
Outdated
| tokio::select! { | ||
| biased; | ||
| _ = shutdown.clone() => { | ||
| break Err(LightningError::TrackPaymentError("Shutdown before tracking results".to_string())); |
There was a problem hiding this comment.
I also think it is worth considering that, if a shutdown signal is raised, we may want to wait until the next tick before stopping the simulation.
This would certainly need a followup, but I think it is worth we discuss it (and we open an issue for it if it makes sense)
There was a problem hiding this comment.
wait until the next tick before stopping the simulation
would that be a tick in the current track payment task, i.e 1 second later? how would we "harmonize waiting" for all the other timers and timeouts?
There was a problem hiding this comment.
What I had in mind is, when a shutdown is triggered:
- First, you stop the producers, so no new payments are passed down the pipeline
- Then you wait for whatever we feel is reasonable for inflight payments to complete
There was a problem hiding this comment.
concept ack. I created a tracking issue here: #82
| let payment_outcome = match payment_status { | ||
| ListpaysPaysStatus::Pending => continue, | ||
| ListpaysPaysStatus::Complete => PaymentOutcome::Success, | ||
| // Task: https://github.com/bitcoin-dev-project/sim-ln/issues/26#issuecomment-1691780018 |
okjodom
force-pushed
the
cln-track-payment
branch
from
4b9dd98 to
516a52d
Compare
okjodom
force-pushed
the
cln-track-payment
branch
from
516a52d to
c27b8f6
Compare
|
Looks good! Going to find some time to test this in the wild this week, should be good to go after that 🥇 |
|
LGTM too. There is not much we can do regarding tracking without polling atm, and there is an open issue at CLN for the error reporting in |
|
Update: fml, forgot about |
There was a problem hiding this comment.
tACK! Sorry this took me so long to get to.
Tested LND <-> CLN keysend payments, everything as expected + tracked in results.
We do however need to take another look at error handling for sending CLN payments, when I tried to test out failures (just closed the only channel) I get an error that shuts down the simulation:
ERROR [sim_lib] Error while sending payment 0366dc9e42d6cb2a89d3ba9a347a0995c88e62949618db6f62bd86fd1da0364868
-> 02c0c6b8be1a367c2fce4efdd9ea075b1e2b15d2566c6eab845513a88e313ee0ab.
Terminating consumer. Send payment error status:
Unknown, message: "Error calling method KeySend: RpcError {
code: Some(210), message: \"Ran out of routes to try after 1 attempt: see `paystatus`\" }", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Mon, 11 Sep 2023 15:48:33 GMT", "content-length": "0"}
}
Created #96 to track!
Polls
lightning-listpaysuntil payment completes or fails