Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

batch print results to csv #76

Merged
merged 2 commits into from
Aug 28, 2023
Merged

batch print results to csv #76

merged 2 commits into from
Aug 28, 2023

Conversation

okjodom
Copy link
Collaborator

@okjodom okjodom commented Aug 24, 2023

closes #59

@okjodom okjodom requested a review from sr-gi August 24, 2023 10:42
carlaKC
carlaKC reviewed Aug 25, 2023
View reviewed changes
Copy link
Contributor

@carlaKC carlaKC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! My nitty soul wants to call this batch_size across the board (since that's a somewhat known term in lightning land) but non-blocking .

Would like to update the default then this can sheep 🚢

sim-lib/src/lib.rs Outdated Show resolved Hide resolved
sim-lib/src/lib.rs Outdated Show resolved Hide resolved
okjodom added 2 commits August 27, 2023 08:49
@okjodom
sim-lib: batch write results to file
d9f8b89 
- this will write to file after every 500 results have been buffered, or
  at any time the simulation is interrupted
@okjodom
sim-cli: configure batch print from cli
11bc783 
- sim-lib also keeps a default batch size of 500 results to print
@okjodom
Copy link
Collaborator Author

okjodom commented Aug 27, 2023

latest update: I dropped the csv patch because I was wrong and didn't need it

@carlaKC carlaKC self-requested a review August 28, 2023 08:30
carlaKC
carlaKC approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@carlaKC carlaKC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, tested batch of 15 with 30 payments and manually checked that it writes in 2 batches 🔥

@carlaKC
Copy link
Contributor

carlaKC commented Aug 28, 2023

@okjodom hit the button on this if you're ready!

@okjodom okjodom merged commit a5003f2 into bitcoin-dev-project:main Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlaKC carlaKC carlaKC approved these changes

@sr-gi sr-gi Awaiting requested review from sr-gi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Robustness: Batched export of CSV Results
2 participants
@okjodom @carlaKC