Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android instrumentation tests in CI #243

Closed
thunderbiscuit opened this issue Sep 9, 2022 · 3 comments · Fixed by #282 or #414
Closed

Fix Android instrumentation tests in CI #243

thunderbiscuit opened this issue Sep 9, 2022 · 3 comments · Fixed by #282 or #414
Assignees
Labels
CI Continuous integration pipeline related platform: android

Comments

@thunderbiscuit
Copy link
Member

The CI should run the instrumented tests.

@thunderbiscuit thunderbiscuit transferred this issue from bitcoindevkit/bdk-kotlin Nov 15, 2022
@notmandatory notmandatory changed the title Android instrumentation tests do not run in CI Remove unneeded Android instrumentation tests in CI Nov 17, 2022
@notmandatory notmandatory added CI Continuous integration pipeline related platform: android labels Nov 17, 2022
@thunderbiscuit thunderbiscuit changed the title Remove unneeded Android instrumentation tests in CI Fix Android instrumentation tests in CI Dec 15, 2022
@notmandatory notmandatory added this to the Release 0.27.0 milestone Jan 16, 2023
@thunderbiscuit
Copy link
Member Author

Running tests in the emulator on CI is currently creating some issues for us because

  1. Ubuntu images are notorious for not working well with emulators
  2. Connected Android tests should usually be run on macOS images, but the NDK version we're using is now deprecated on all GitHub macOS images, and so it needs to be added manually, but for some reason this is throwing errors.

I have opened a PR to fix this (#282) but over the course of my research on the issue I have come to the conclusion that we might be creating our own problem here by using such an old version of the NDK. The latest LTS version is r25c and we're on 21. Looking into whether we might be able to update to the NDK maintained in the GitHub macOS latest image, which would be 25.1.8937393.

@thunderbiscuit
Copy link
Member Author

thunderbiscuit commented Feb 3, 2023

Something about the ring library creating problems when updating to a different NDK.

Links: briansmith/ring#486

Error:

warning: In file included from <built-in>:382:
warning: <command line>:2:9: warning: '__ANDROID_API__' macro redefined [-Wmacro-redefined]
warning: #define __ANDROID_API__ 21
warning:         ^
warning: <built-in>:376:9: note: previous definition is here
warning: #define __ANDROID_API__ __ANDROID_MIN_SDK_VERSION__
warning:         ^

@thunderbiscuit
Copy link
Member Author

thunderbiscuit commented Feb 3, 2023

I tried to update the NDK to the minimum version that ships on the macos-12 image (23.2.8568313). No dice.

@thunderbiscuit thunderbiscuit removed this from the Release 0.27.1 milestone Mar 24, 2023
notmandatory added a commit that referenced this issue Apr 13, 2023
…and publish workflows

beb75dd Use version 21 of the Android NDK in the CI test, build, and publish workflows (thunderbiscuit)

Pull request description:

  This PR reverts an update to our Android CI workflows.

  For info on why this is needed, see issues #242 and #243.

ACKs for top commit:
  notmandatory:
    ACK beb75dd

Tree-SHA512: dfee0b1f335318b86fa490fa85e7ef5d7a032e01a78db64a186c5d75e9e77e8f0e2af58ee5407d4fe38a0aa3aabbc7b06b23189aef0dfaad1d246a354452870d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration pipeline related platform: android
Projects
Archived in project
Status: Done
2 participants