-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Android instrumentation tests in CI #243
Comments
Running tests in the emulator on CI is currently creating some issues for us because
I have opened a PR to fix this (#282) but over the course of my research on the issue I have come to the conclusion that we might be creating our own problem here by using such an old version of the NDK. The latest LTS version is r25c and we're on 21. Looking into whether we might be able to update to the NDK maintained in the GitHub macOS latest image, which would be 25.1.8937393. |
Something about the ring library creating problems when updating to a different NDK. Links: briansmith/ring#486 Error: warning: In file included from <built-in>:382:
warning: <command line>:2:9: warning: '__ANDROID_API__' macro redefined [-Wmacro-redefined]
warning: #define __ANDROID_API__ 21
warning: ^
warning: <built-in>:376:9: note: previous definition is here
warning: #define __ANDROID_API__ __ANDROID_MIN_SDK_VERSION__
warning: ^ |
I tried to update the NDK to the minimum version that ships on the macos-12 image ( |
…and publish workflows beb75dd Use version 21 of the Android NDK in the CI test, build, and publish workflows (thunderbiscuit) Pull request description: This PR reverts an update to our Android CI workflows. For info on why this is needed, see issues #242 and #243. ACKs for top commit: notmandatory: ACK beb75dd Tree-SHA512: dfee0b1f335318b86fa490fa85e7ef5d7a032e01a78db64a186c5d75e9e77e8f0e2af58ee5407d4fe38a0aa3aabbc7b06b23189aef0dfaad1d246a354452870d
The CI should run the instrumented tests.
The text was updated successfully, but these errors were encountered: