Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies for Compatibility and Security (Fixes #1797) #1804

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yaegeristhitesh
Copy link

@yaegeristhitesh yaegeristhitesh commented Jan 18, 2025

Description

This pull request addresses Issue #1797 and updates several dependencies in the project:

  • bdk_chain: Updated rusqlite from 0.31.0 to 0.32.1 for improved compatibility and security.
  • bdk_chain: Updated criterion from ^0.2 to 0.5.1 in dev dependencies for bug fixes and new features.
  • bdk_testenv: Updated electrsd from ^0.28.0 to 0.29.0 to ensure compatibility with the latest versions of electrs.
  • example_wallet_rpc and example_bitcoind_rpc_polling: Updated ctrlc from ^2 to 3.4.5 for better compatibility with newer versions of ctrlc.

Notes to the reviewers

  • The updates address part of Issue Update out of date dependencies #1797. A key point is the security vulnerability related to tokio (RUSTSEC-2023-0001). The fix is pending as part of future updates.
  • There is still one more dependency update (hashbrown) in the bdk_core crate left to complete. This will be addressed in a subsequent PR.
  • Testing is focused on ensuring the stability and compatibility of the crates after these updates. Please pay particular attention to the interaction between rusqlite, criterion, electrsd, and ctrlc.

Changelog notice

  • Updated several dependencies to newer, more secure versions.
    • rusqlite updated to 0.32.1.
    • criterion updated to 0.5.1.
    • electrsd updated to 0.29.0.
    • ctrlc updated to 3.4.5.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

…xamples (fixes bitcoindevkit#1797)

- `bdk_chain`: updated `rusqlite` from `0.31.0` to `0.32.1` to address compatibility and security improvements.
- `bdk_chain`: updated `criterion` from `^0.2` to `0.5.1` in dev dependencies to leverage newer features and bug fixes.
- `bdk_testenv`: updated `electrsd` from `^0.28.0` to `0.29.0` for improved compatibility with the latest versions of `electrs`.
- `example_wallet_rpc` and `example_bitcoind_rpc_polling`: updated `ctrlc` from `^2` to `3.4.5` to ensure compatibility with the latest versions of `ctrlc`.

These updates aim to improve compatibility, performance, and security across relevant crates.
@yaegeristhitesh
Copy link
Author

Gentle Reminder
Please approve my PR so that i can proceed to submitting commits regarding remaining fixes of the issue #1797.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant