Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zizmor github actions security analysis workflow #1813

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

notmandatory
Copy link
Member

Description

Added workflow to run zizmor github actions security analysis.

See: https://woodruffw.github.io/zizmor/usage/#use-in-github-actions

Notes to the reviewers

I built this PR on top of #1778.

Changelog notice

  • fix(ci): do not persist credentials
  • ci: add zizmor github actions security analysis workflow

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory requested review from ValuedMammal and removed request for ValuedMammal January 28, 2025 02:26
@notmandatory notmandatory self-assigned this Jan 28, 2025
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@notmandatory notmandatory added this to the 1.1.0 milestone Jan 28, 2025
@notmandatory notmandatory changed the title Ci/zizmor Add zizmor github actions security analysis workflow Jan 28, 2025
@notmandatory
Copy link
Member Author

Rebased on updated and merged #1778 ready to review and merge, zizmor finds no issues now.

Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good and it's a pretty good addition.

I left a minor comment and another one regarding my concerning on relying on another action for what it seems just python package management.

Comment on lines +16 to +17
contents: read
actions: read
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a public repo, this could be removed ?

Comment on lines +24 to +30
- name: Install the latest version of uv
uses: astral-sh/setup-uv@v5

- name: Run zizmor 🌈
run: uvx zizmor --format sarif . > results.sarif
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of having a zizmor job, however, I'm wondering if there's another simpler/safer way to run it, instead of bringing this new action (setup-uv) AFAICT just for the python package manager 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

2 participants