[bug-fix] Set the sync time in populate test db. #717
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After recent changes in balance calculation, the
get_funded_wallet
test function will not show any balance because we are not setting thesync_time
in thepopulate_test_db
macro..Our existing tests are not failing, because even if the balance is shown zero, it will still be able to produce transactions. But its causing test failure in downstream
bdk-reserves
crate where the balances are required to assert scenarios.Notes to the reviewers
This will be replayed in #624 too, as this function is being refactored there.. For now opening it as separate PR for quick merge.
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingBugfixes: