Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applying blocks API #896

Closed
wants to merge 2 commits into from
Closed

Applying blocks API #896

wants to merge 2 commits into from

Conversation

danielabrozzoni
Copy link
Member

@danielabrozzoni danielabrozzoni commented Mar 16, 2023 •
edited
Loading

Closes #903

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@danielabrozzoni danielabrozzoni force-pushed the applying_blocks branch 2 times, most recently from 462d2e5 to 88386ef Compare March 16, 2023 16:38
@danielabrozzoni danielabrozzoni changed the title Applying blocks Applying blocks API Mar 16, 2023
@danielabrozzoni
Add utilities for applying blocks
1f85fc2 
- ChainGraph::determine_relevant_changeset
- KeychainTracker::determine_relevant_changeset,
  KeychainTracker::determine_additions,
  KeychainTracker::apply_update_relevant,
- TxGraph::determine_relevant_additions
@danielabrozzoni
Test determine_relevant_changeset
f8043bc
@notmandatory
Copy link
Member

@danielabrozzoni does this PR need to be rebase/worked now that that #976 is merge?

@danielabrozzoni
Copy link
Member Author

I'm really not sure, @evanlinjin is this PR still needed?

@evanlinjin
Copy link
Member

I'm really not sure, @evanlinjin is this PR still needed?

It definitely needs further discussion. It depends if everyone is happy with my approach in #1041, or do we feel that having an apply_blocks method is strictly better?

@nondiremanuel nondiremanuel mentioned this pull request Aug 8, 2023
Closed
26 tasks
@LLFourn
Copy link
Contributor

LLFourn commented Aug 9, 2023

I'm really not sure, @evanlinjin is this PR still needed?

It definitely needs further discussion. It depends if everyone is happy with my approach in #1041, or do we feel that having an apply_blocks method is strictly better?

I think having apply_block is a better approach after reviewing #1041.

@nondiremanuel nondiremanuel mentioned this pull request Aug 22, 2023
Closed
30 tasks
@danielabrozzoni
Copy link
Member Author

Closing as the approach changed radically anyways

@danielabrozzoni danielabrozzoni mentioned this pull request Oct 11, 2023
Closed
@danielabrozzoni danielabrozzoni deleted the applying_blocks branch October 11, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@danielabrozzoni danielabrozzoni

Labels
None yet
Projects
BDK
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Applying blocks APIs
4 participants
@danielabrozzoni @notmandatory @evanlinjin @LLFourn