-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add review club #147
Add review club #147
Conversation
✅ Deploy Preview for awesome-golick-685c88 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Aside from the custom properties add filter for date formatting and helper methods for sorting meeting pages according to the most recent.
929a831
to
4cbc1fd
Compare
4cbc1fd
to
2a504d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
At the top of that file. Add the following frontmatter content | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I will fix that.
I am willing to help maintain this if we ever implement :) |
Closing this now as we're not quite ready to host a PR review club on a steady basis. Feel free to reopen when it's a good time! |
This PR ports the Bitcoin Core review site to a section on our BDK website.
I maintained the styling from the Bitcoin Core review site instead of going with our own website theme.
I also maintained IRC as the meeting location.
I think the website is ready to be used, at least for our next meeting. There are still some nits that can be improved upon like having multiple navs on the meetings page as the bitcoin core website page.
These will be worked on future PRs.
I have kind of messed up the navigation, currently working on fixing it.