Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add review club #147

Closed

Conversation

vladimirfomene
Copy link
Contributor

@vladimirfomene vladimirfomene commented Jun 13, 2023

This PR ports the Bitcoin Core review site to a section on our BDK website.
I maintained the styling from the Bitcoin Core review site instead of going with our own website theme.
I also maintained IRC as the meeting location.
I think the website is ready to be used, at least for our next meeting. There are still some nits that can be improved upon like having multiple navs on the meetings page as the bitcoin core website page.
These will be worked on future PRs.
I have kind of messed up the navigation, currently working on fixing it.

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for awesome-golick-685c88 ready!

Name Link
🔨 Latest commit fbdb288
🔍 Latest deploy log https://app.netlify.com/sites/awesome-golick-685c88/deploys/648ee84c8ce8b5000868ec3b
😎 Deploy Preview https://deploy-preview-147--awesome-golick-685c88.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@danielabrozzoni danielabrozzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up, there are some CSS issues
Selection_192
Selection_193


At the top of that file. Add the following frontmatter content

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be empty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I will fix that.

@realeinherjar
Copy link

I am willing to help maintain this if we ever implement :)

@thunderbiscuit
Copy link
Member

Closing this now as we're not quite ready to host a PR review club on a steady basis. Feel free to reopen when it's a good time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants