Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new groupfeature breaks checkbox in logblocks #434

Closed
knmcguire opened this issue Aug 26, 2020 · 1 comment
Closed

new groupfeature breaks checkbox in logblocks #434

knmcguire opened this issue Aug 26, 2020 · 1 comment
Milestone
2020.09

Comments

@knmcguire
Copy link
Contributor

It is due to the slash of the log config groups which was added in this PR #415. This should be replaced by a dash '-'
knmcguire added a commit that referenced this issue Sep 1, 2020
@knmcguire
(#434) replace cvs file name string for groupslogs with dash instead …
a2e39d3 
…of slash in logblocks
@knmcguire
Copy link
Contributor Author

Just before the cvs file name is created, the slash is replaced by a dash. I like the slash for the plotter and logblock tabs since it is clear that is part of a group. As long as this is fixed before the log cvs file is saved this should be okay.

@knmcguire knmcguire added this to the next-release milestone Sep 1, 2020
knmcguire added a commit that referenced this issue Sep 1, 2020
@knmcguire
(#434) fixd flake8 issue
2f53781
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2020.09
Development

No branches or pull requests
1 participant
@knmcguire