Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credits not shown in about box when installed with pip #442

Closed
ataffanel opened this issue Sep 13, 2020 · 1 comment · Fixed by #478
Closed

Credits not shown in about box when installed with pip #442

ataffanel opened this issue Sep 13, 2020 · 1 comment · Fixed by #478
Labels
app:cfclient bug
Milestone
2021.3

Comments

@ataffanel
Copy link
Member

When the client is installed with pip, either with pip3 install . or pip3 install cfclient, the credits are not show in the about box.

This is likely due to the fact that the file CREDITS.txt is not copied in the distribution package by setup.py.
@ataffanel ataffanel added this to the next-release milestone Sep 13, 2020
jonasdn added a commit to jonasdn/crazyflie-clients-python that referenced this issue Mar 9, 2021
@jonasdn
Replace CREDITS.txt with link to GitHub insights
b600b85 
In order to avoid updating, distributing and installing the CREDITS.txt
file we instead linkt to the GitHub contributor graphs.

Closes bitcraze#442
@jonasdn jonasdn mentioned this issue Mar 9, 2021
Merged
@jonasdn
Copy link
Contributor

jonasdn commented Mar 9, 2021

My proposal is to drop CREDITS.txt to avoid the hassle of updating, distributing and installing it. Instead link to GitHub graphs in client. See PR #478

jonasdn added a commit to jonasdn/crazyflie-clients-python that referenced this issue Mar 10, 2021
@jonasdn
Replace CREDITS.txt with link to GitHub insights
f400d4c 
In order to avoid updating, distributing and installing the CREDITS.txt
file we instead linkt to the GitHub contributor graphs.

The "Used libraries" part is deleted because it was out-of-date and we
do not have any nice tooling or process of keeping it up-to-date.

Closes bitcraze#442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app:cfclient bug
Projects
None yet
Milestone
2021.3
Development

Successfully merging a pull request may close this issue.

Replace CREDITS.txt with link to GitHub insights jonasdn/crazyflie-clients-python
2 participants
@jonasdn @ataffanel