Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut keys for quit client and connect input device. #339

Merged
merged 4 commits into from
Apr 16, 2018

Conversation

Mitteau
Copy link
Contributor

@Mitteau Mitteau commented Mar 27, 2018

For keyboard "aficionados"... two shortcuts, to exit client and to connect to the found crazyflie. Also better battery display including voltage values. It's useful to have more information on the status of the battery installed.

Shortcut keys for quit client and connect input device. Also:
Battery voltage shown in Main UI.
Adapt voltage limits for battery.

Modifications:
modified : src/cfclient/ui/main.py
modified : src/cfclient/ui/main.ui

Battery voltage shown in Main UI.
Adapt voltage limits for battery.

 Modifications qui seront validées :
	modifié :         src/cfclient/ui/main.py
	modifié :         src/cfclient/ui/main.ui
@Mitteau
Copy link
Contributor Author

Mitteau commented Apr 3, 2018

I don't know how to modify the RFP. So I can't solve Travis error which is due to a too long line in the code... Do this commit interests you or do I close it?

@krichardsson
Copy link
Contributor

Hi!

Nice functionality!
I would prefer to keep the caption of the button as it used to be though, and move the "Ctrl+I" part to the tool tip to be displayed when hovering over the button. If you add the shortcut to the "Connect to Crazyflie" menu item as well, it will be displayed in the menu and guide the user.

For the line that is too long (206 in main.py), just break the line after QShortcut(

        self.connect_input = QShortcut(
            "Ctrl+I", self.connectButton, self._connect)

Jean-Claude Mitteau added 3 commits April 10, 2018 09:55
 Modifications qui seront validées :
	modifié :         src/cfclient/ui/main.py
	modifié :         src/cfclient/ui/main.ui
 Modifications qui seront validées :
	modifié :         src/cfclient/ui/main.py
	modifié :         src/cfclient/ui/main.ui
 Modifications qui seront validées :
	modifié :         src/cfclient/ui/main.py
@krichardsson krichardsson merged commit 6e7bab1 into bitcraze:master Apr 16, 2018
@krichardsson
Copy link
Contributor

Merged
Thanks!

@krichardsson krichardsson added this to the next_release milestone Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants