-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added QualisysTab #355
Added QualisysTab #355
Conversation
Thanks for the PR! |
Yeah, I heard that from Martin. (from what I can see, the tab had the same issues before my changes) The other option(in my opinion, less desirable) is to simply add an input box for the qtm ip. Which path would you prefer? |
I though this was the reason why the discovery was not working. Interfaces have quite random name in Linux nowadays. A box with the IP would be good enough for me. Discovery is nice but when working with this kind of system we usually know about the IP or hostname (it is needed for crazyswarm for example). |
Refactored discovery Added Scan button
I've quickly tested the pull request and some initial feedback.
|
|
Alright, all UI modification should be done on the UI thread now. Haven't got any ubuntu machines to test on here, so when you got the time... I think you said you could/had already solved the other two issues? |
@tobbeanton, @ataffanel |
Sorry for the late reply! We tested a bit and found some problems that must be fixed before we can merge.
The first 4 should be fairly easy to fix while the 5th is a bit more fuzzy. Please let us know if you need any help.
|
We found a fix for 5. (not that we understand it), it was caused by the line |
Think I've fixed all the issues. |
Merged! Thanks! |
* Removed unnecessary SyncCrazyflie * Using correct function to send position to CF
Adds the Qualisys Tab to cfclient.
Add dependencies of two pure python packages, qtm & quamash.
quamash is used to create an eventloop that works with both Qt and asyncio
Will raise the required Python version to 3.5.2