Add support for flashing the lighthouse deck FW from the bootloader dialog #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krichardsson
changed the title
jonasdn
reviewed
Mar 9, 2021
| if filename != "" and filename[-4:] in (".bin", ".zip"): | ||
| names = QtWidgets.QFileDialog.getOpenFileName( | ||
| self, 'Release file to flash', self._helper.current_folder, "*.zip") | ||
| if names[0] == '': |
There was a problem hiding this comment.
nit: in python empty strings are falsy meaning this could be: if not names[0]:
| filename = names[0] | ||
| self._helper.current_folder = os.path.dirname(filename) | ||
|
|
||
| if filename[-4:] in ('.zip'): |
There was a problem hiding this comment.
nit: this might now be more clearer as:
if filename[-4:] == '.zip':
or better yet:
if filename.endswith('.zip'):
jonasdn
reviewed
Mar 9, 2021
Comment on lines
-189
to
-193
| self._auto_reconnect_enabled = Config().get("auto_reconnect") | ||
| self.autoReconnectCheckBox.toggled.connect( | ||
| self._auto_reconnect_changed) | ||
| self.autoReconnectCheckBox.setChecked(Config().get("auto_reconnect")) | ||
|
|
There was a problem hiding this comment.
What is the reason for removing this? Could it be stated in the commit message?
jonasdn
approved these changes
Mar 11, 2021
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for flashing decks from the boot loader dialog.
Initially for the lighthouse deck, but will also work for other decks that have FW in the future.
To simplify the user experience we will remove the possibility of flashing .bin files, only .zip files will be supported. Also all flashing targets will be used when flashing and option to chose flashing targets will be removed. The user should use developer functionality (make cload) to flash a single target.
The flashing procedure will contain restart(s) in some cases. Since the boot loader dialog now also handles connections to the CF, we will remove the auto-reconnect feature to avoid and complications when re-booting.
Related issues: