LogClientTab: Use stand-alone logging class #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we use a QT widget as a Loghandlet we get spooky actions at exit:
```
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
File "/usr/lib/python3.8/logging/__init__.py", line 2115, in shutdown
h.close()
RuntimeError: wrapped C/C++ object of type LogClientTab has been deleted
```
Fixes: bitcraze/crazyflie-lib-python#210
jonasdn
requested review from
ataffanel,
evoggy,
knmcguire,
krichardsson and
tobbeanton
whoenig
requested changes
Mar 22, 2021
| class LogClientTab(Tab, log_client_tab_class, logging.StreamHandler): | ||
| class LogHandler(logging.StreamHandler): | ||
| def __init__(self, signal): | ||
| logging.StreamHandler.__init__(self) |
There was a problem hiding this comment.
this is a scary way of doing it. I think recommended in Python3 would be super().init(), but in this particular case you should be able to just remove this line, since the ctor doesn't require any arguments.
|
This looks good as is. Lets merge it to get rid of this crash in the new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use a QT widget as a Loghandler we get spooky actions at exit:
Fixes: bitcraze/crazyflie-lib-python#210