Fix install from source #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ataffanel
force-pushed
the
ataffanel/issue504
branch
from
12f6ccc to
a1d8745
Compare
|
It is an ok stop-gap solution. We can fix it nicer to next version. |
jonasdn
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the minimal change to fix install from souce.
The problem was that if we are not in a git repos, VERSION needs to be set to None and the version if found in a json file.
This still look a bit bad though. Maybe the version should be fetched from python instead. The release taball contains a file named
PKG-INFO, it might be cleaner to get the version from there instead?