main: warn once about USB permissions on scan #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user press the scan button and we get a Permissions Denied error from the USB core then we know that the Crazyradio dongle is present, but we cannot access it. We will warn, once, about this with a message box that gives a link to instructions on how to install the udev files. Closes #444
|
I prefer this to automagicly installing udev files. It feels icky to handle root powers in the client. |
ataffanel
approved these changes
Sep 8, 2021
There was a problem hiding this comment.
I can agree that avoiding to handle root permission if we do not have to is good.
I like it and I think this is going to remove a huge paper-cut to the client on Linux!
The doc that is linked likely needs to be improved a bit: would be nice to provide a block that can be copy-pasted in a console. I can prepare a PR to the lib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user press the scan button and we get a Permissions Denied
error from the USB core then we know that the Crazyradio dongle is
present, but we cannot access it.
We will warn, once, about this with a message box that gives a link
to instructions on how to install the udev files.
Closes #444