Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify tabs and toolboxes #622

Merged
merged 13 commits into from
Aug 4, 2022
Merged

Unify tabs and toolboxes #622

merged 13 commits into from
Aug 4, 2022

Conversation

krichardsson
Copy link
Contributor

@krichardsson krichardsson commented Aug 3, 2022

This PR changes the behavior of tabs and toolboxes to make them interchangeable, that is all tabs can also be used as toolboxes. Since toolboxes can be docked to the sides of the main window, this makes it possible to see multiple tabs/toolboxes at the same time.

  • Unify tabs and toolboxes
  • Menu support
  • Basic storage in config
  • Store toolbox position in config
  • Drag and drop between toolbox and tab state
  • Documentation

@krichardsson krichardsson marked this pull request as draft August 3, 2022 09:02
@krichardsson
Copy link
Contributor Author

I'm not sure how to implement drag and drop from tab to toolbox, I'll skip this for now.

@knmcguire
Copy link
Contributor

This is really nice!

I've noticed some issues with the vispy tabs which are probably just a vispy issue, but perhaps we could maybe consider leaving the loco and lighthouse toolboxes out?

WARNING: Error drawing visual <vispy.visuals.mesh.MeshVisual object at 0x000001F4EDA9ABF0>
WARNING:vispy:Error drawing visual <vispy.visuals.mesh.MeshVisual object at 0x000001F4EDA9ABF0>
WARNING: Error drawing visual <vispy.visuals.mesh.MeshVisual object at 0x000001F4EDA9ABF0>
WARNING:vispy:Error drawing visual <vispy.visuals.mesh.MeshVisual object at 0x00000

Also I noticed that I couldn't properly dock the tuning tab with the following issue:

WARNING: QMainWindow::addDockWidget: invalid 'area' argument
WARNING:vispy:QMainWindow::addDockWidget: invalid 'area' argument

In the beginning I was but then I broke it out of the cfclient and after that I got this error, but removing the config file resolves the beginning part at least.

Perhaps we can hope for that people won't do too many crazy stuff with the tabs to reach these?

@krichardsson
Copy link
Contributor Author

Yeah, there are some "features" in QT that is out of our control. I think this PR is good enough to be merged. Even though it is not perfect, it will add value

@krichardsson krichardsson marked this pull request as ready for review August 4, 2022 13:04
@krichardsson krichardsson merged commit f12da70 into master Aug 4, 2022
@krichardsson krichardsson deleted the krichardsson/tab-toolbox branch August 4, 2022 13:04
@knmcguire knmcguire added this to the next-release milestone Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants