-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify tabs and toolboxes #622
Conversation
the console toolbox
I'm not sure how to implement drag and drop from tab to toolbox, I'll skip this for now. |
This is really nice! I've noticed some issues with the vispy tabs which are probably just a vispy issue, but perhaps we could maybe consider leaving the loco and lighthouse toolboxes out?
Also I noticed that I couldn't properly dock the tuning tab with the following issue:
In the beginning I was but then I broke it out of the cfclient and after that I got this error, but removing the config file resolves the beginning part at least. Perhaps we can hope for that people won't do too many crazy stuff with the tabs to reach these? |
Yeah, there are some "features" in QT that is out of our control. I think this PR is good enough to be merged. Even though it is not perfect, it will add value |
This PR changes the behavior of tabs and toolboxes to make them interchangeable, that is all tabs can also be used as toolboxes. Since toolboxes can be docked to the sides of the main window, this makes it possible to see multiple tabs/toolboxes at the same time.
Drag and drop between toolbox and tab state