Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check opencv install in LighthouseBsGeoEstimator #625

Merged
merged 4 commits into from
Aug 15, 2022
Merged

Conversation

knmcguire
Copy link
Contributor

This checks if the opencv library is installed according to the cflib. This goes together with this PR bitcraze/crazyflie-lib-python#353

Behavior:
Newest CFlib (from PR) + cfclient (this pr): the button opencv geo estimator is grayed out by default
older cflib (latest release or before this pr) + cfclient (this pr): Exception when trying out opencv based estimator
newest cflib (from pr) + cfclient latest release or before pr): Exception when trying out opencv based estimator

@knmcguire
Copy link
Contributor Author

by review of kristoffer, I should remove the indication that it is an opencv based geometry, but rather call it 'simple'

@knmcguire knmcguire marked this pull request as ready for review August 15, 2022 11:38
@krichardsson krichardsson merged commit f1b926b into master Aug 15, 2022
@krichardsson krichardsson deleted the check-opencv branch August 15, 2022 11:57
@knmcguire knmcguire added this to the next-release milestone Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants