Fix bug by making decimal input handling locale-independent #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses a critical bug where decimal inputs in the X range values were not processed correctly in locales that use a comma as the decimal separator. By replacing commas with dots, we ensure that numeric inputs are handled consistently across all locales, making the application's numeric input processing locale-independent. This update sidesteps the complexities associated with using the `locale` module, providing a straightforward but dirty solution to the issue. Co-authored-by: Tobias Antonson <[email protected]>
ToveRumar
approved these changes
Jul 3, 2024
ataffanel
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
This is indeed not the most elegant solution and my main problem is that the GUI does not respect the user's local. However this is how the client is currently working and this PR works. I tried to break it with setting big number and setting my local to include group separators (100.000,00) but I could not find a case where it broke. So this works fine, great efficient work!
|
Thanks for the reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a critical bug where decimal inputs in the plotter's X range values were not processed correctly in locales that use a comma as the decimal separator. By replacing commas with dots, we ensure that numeric inputs are handled consistently across all locales, making the application's numeric input processing locale-independent.
This update sidesteps the complexities associated with using the
localemodule, providing a straightforward but dirty solution to the issue.