Refactor HiltViewModels ApplicationContext #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnau Mora <[email protected]>
rfc2822
requested changes
Oct 16, 2023
Signed-off-by: Arnau Mora <[email protected]>
rfc2822
requested changes
Oct 16, 2023
There was a problem hiding this comment.
There are still some without @HiltViewModel; guess it won't work without? Please check for all changed code occurrences manually (for instance let the open-source fragment display at startup).
If ready, please explicitly re-request review so that I know when you're finished.
app/src/main/kotlin/at/bitfire/davdroid/ui/intro/OpenSourceFragment.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Arnau Mora <[email protected]>
…ntext # Conflicts: # app/src/main/kotlin/at/bitfire/davdroid/ui/intro/BatteryOptimizationsFragment.kt # app/src/main/kotlin/at/bitfire/davdroid/ui/webdav/AddWebdavMountActivity.kt
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
rfc2822
requested changes
Oct 19, 2023
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/AccountDetailsFragment.kt
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/ui/intro/BatteryOptimizationsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/ui/webdav/AddWebdavMountActivity.kt
Show resolved
Hide resolved
rfc2822
added
refactoring
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
|
Now everything should be fine I believe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.