[bitnami/external-dns] IRSA docs added #4682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dani8art
requested changes
Dec 11, 2020
There was a problem hiding this comment.
Hi @AntonAleksandrov13 thank you for the PR, please, take a look at my comments.
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
Hi @AntonAleksandrov13 did you have a chance to work on this? |
|
sorry, totally forgot about it. I will do that |
|
Please check the PR |
Cellebyte
pushed a commit
to Cellebyte/charts
that referenced
this pull request
Feb 12, 2021
* IRSA docs added * Version bump * Added example arguments * Updated version * Removed new line * Added new line in yaml file + removed line in docs Co-authored-by: Anton Aleksandrov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Docs update for users who are deploying to AWS EKS and use IRSA
Benefits
This information is only available here
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.[bitnami/chart])values-production.yamlapart fromvalues.yaml, ensure that you implement the changes in both files