Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix]update node_controller.go #857

Merged
merged 4 commits into from
Jan 4, 2023
Merged

[bugfix]update node_controller.go #857

merged 4 commits into from
Jan 4, 2023

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Oct 14, 2022 •
edited
Loading

Reproduction steps:

  1. Start mysql-operator.
  2. Start the mysql instance.
  3. Wait for all mysql instances to run successfully.
  4. Close mysql-operator (to simulate network failure, node down, etc.).
  5. Restart the node containing the mysql instance(Machine reboot).
  6. The mysql instances on these nodes will start automatically, but since init will set configfure to 0.
  7. Wait for all these nodes to stop changing.
  8. Start mysql-operator, which will not automatically repair the current cluster because it is listening to the updated pod.
  9. and the mysql cluster is in an unhealthy state due to configfure=0.

closes/fixes #xyz

  • I've made sure the CHANGELOG.md will remain up-to-date after this PR is merged.

@jiuker
update node_controller.go
493a7e8 
Reproduction steps:
1. Start mysql-operator.
2. Start the mysql instance.
3. Wait for all mysql instances to run successfully.
4. Close mysql-operator (to simulate network failure, node down, etc.).
5. Restart the node containing the mysql instance.
6. The mysql instances on these nodes will start automatically, but since init will set configfure to 0.
7. Wait for all these nodes to stop changing.
8. Start mysql-operator, which will not automatically repair the current cluster because it is listening to the updated pod.
9. and the mysql cluster is in an unhealthy state due to configfure=0.
@jiuker
Copy link
Contributor Author

jiuker commented Oct 14, 2022

@cndoit18

@jiuker
Copy link
Contributor Author

jiuker commented Oct 14, 2022

img

operator will do noting @cndoit18

@jiuker jiuker requested a review from cndoit18 October 25, 2022 06:35
@jiuker
Copy link
Contributor Author

jiuker commented Oct 25, 2022

@cndoit18

@jiuker
Copy link
Contributor Author

jiuker commented Oct 25, 2022 •
edited
Loading

@cndoit18 I have done changelogs.

@jiuker jiuker requested a review from cndoit18 October 25, 2022 06:50
@jiuker
Copy link
Contributor Author

jiuker commented Oct 31, 2022

@cndoit18 any suggestion？

@jiuker
Copy link
Contributor Author

jiuker commented Jan 4, 2023

@cndoit18
@milero

@zgfh
Copy link

zgfh commented Jan 4, 2023

@cndoit18
@milero
PTAL

@jiuker jiuker requested a review from cndoit18 January 4, 2023 02:22
@cndoit18 cndoit18 merged commit eadf620 into bitpoke:master Jan 4, 2023
@panpan0000
Copy link

does it fix this issue #416 ?

@odoucet
Copy link

odoucet commented Jul 30, 2024

does it fix this issue #416 ?

We are using bitpoke operator 0.6.3 and encountered bug #416 today, so no, it does not fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cndoit18 cndoit18 Awaiting requested review from cndoit18

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jiuker @zgfh @panpan0000 @odoucet @cndoit18