Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go 1.23 #337

Merged
merged 4 commits into from
Jan 20, 2025
Merged

Upgrade to Go 1.23 #337

merged 4 commits into from
Jan 20, 2025

Conversation

ofalvai
Copy link
Contributor

@ofalvai ofalvai commented Jan 17, 2025

Also fixes these vulns:

=== Symbol Results ===

Vulnerability #1: GO-2024-2963
    Denial of service due to improper 100-continue handling in net/http
  More info: https://pkg.go.dev/vuln/GO-2024-2963
  Standard library
    Found in: net/[email protected]
    Fixed in: net/[email protected]
    Vulnerable symbols found:
      #1: http.Client.Do
      #2: http.Client.Get
      #3: http.Get
      #4: http.Transport.CancelRequest
      #5: http.Transport.CloseIdleConnections
      Use '-show traces' to see the other 1 found symbols

Vulnerability #2: GO-2024-2888
    Mishandling of corrupt central directory record in archive/zip
  More info: https://pkg.go.dev/vuln/GO-2024-2888
  Standard library
    Found in: archive/[email protected]
    Fixed in: archive/[email protected]
    Vulnerable symbols found:
      #1: zip.OpenReader

Vulnerability #3: GO-2024-2887
    Unexpected behavior from Is methods for IPv4-mapped IPv6 addresses in
    net/netip
  More info: https://pkg.go.dev/vuln/GO-2024-2887
  Standard library
    Found in: net/[email protected]
    Fixed in: net/[email protected]
    Vulnerable symbols found:
      #1: netip.Addr.IsGlobalUnicast
      #2: netip.Addr.IsInterfaceLocalMulticast
      #3: netip.Addr.IsLinkLocalMulticast
      #4: netip.Addr.IsLoopback
      #5: netip.Addr.IsMulticast
      Use '-show traces' to see the other 1 found symbols

Vulnerability #4: GO-2024-2687
    HTTP/2 CONTINUATION flood in net/http
  More info: https://pkg.go.dev/vuln/GO-2024-2687
  Standard library
    Found in: net/[email protected]
    Fixed in: net/[email protected]
    Vulnerable symbols found:
      #1: http.CanonicalHeaderKey
      #2: http.Client.Do
      #3: http.Client.Get
      #4: http.Cookie.String
      #5: http.Cookie.Valid
      Use '-show traces' to see the other 99 found symbols

Your code is affected by 4 vulnerabilities from the Go standard library.
This scan also found 1 vulnerability in packages you import and 4
vulnerabilities in modules you require, but your code doesn't appear to call
these vulnerabilities.
Use '-show verbose' for more details.

@@ -166,19 +166,20 @@ func share(c *cli.Context) {
b.NewLine()
b.Plain("Just follow these steps:").NewLine()
b.NewLine()
b.Plain("0. ").Plain(GuideTextForStepAudit(toolMode)).NewLine()

b.Plain("0. ").Plain(GuideTextForStepAudit(toolMode)).NewLine() //nolint:govet
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cli/share.go:172:23: printf: non-constant format string in call to (*github.com/bitrise-io/colorstring.Builder).Plain (govet)
        b.Plain("1. ").Plain(GuideTextForStart()).NewLine()

I think it's okay in this case. The colorstring builder library has no method for printing a non-format-string string

@ofalvai ofalvai merged commit 98789ba into master Jan 20, 2025
4 checks passed
@ofalvai ofalvai deleted the BE-1601-go-1.23 branch January 20, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants