feat: clarify chama updates to add members

bitsacco · Feb 12, 2025 · b73f768 · b73f768
1 parent 28671f0
commit b73f768
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/apps/chama/src/chamas/chamas.service.ts b/apps/chama/src/chamas/chamas.service.ts
@@ -135,8 +135,8 @@ export class ChamasService {
       hunk.description = updates.description;
     }
 
-    if (updates.members) {
-      const registered = await this.resolveMembers(updates.members);
+    if (updates.addMembers) {
+      const registered = await this.resolveMembers(updates.addMembers);
       hunk.members = this.deduplicateMembers(cd.members, registered);
     }
 

diff --git a/libs/common/src/dto/chama.dto.ts b/libs/common/src/dto/chama.dto.ts
@@ -24,6 +24,7 @@ import {
   type FindChamaRequest,
   type JoinChamaRequest,
   type UpdateChamaRequest,
+  type PaginatedRequest,
 } from '../types';
 import { NpubDecorators, PhoneDecorators } from './decorators';
 import { PaginatedRequestDto } from './lib.dto';
@@ -167,7 +168,7 @@ export class ChamaUpdatesDto implements ChamaUpdates {
       },
     ],
   })
-  members: ChamaMember[];
+  addMembers: ChamaMember[];
 }
 
 export class UpdateChamaDto implements UpdateChamaRequest {
@@ -207,7 +208,7 @@ export class FilterChamasDto implements FilterChamasRequest {
   @ValidateNested()
   @Type(() => PaginatedRequestDto)
   @ApiProperty({ type: PaginatedRequestDto })
-  pagination?: PaginatedRequestDto;
+  pagination?: PaginatedRequest;
 }
 
 export class JoinChamaDto implements JoinChamaRequest {

diff --git a/libs/common/src/types/proto/chama.ts b/libs/common/src/types/proto/chama.ts
diff --git a/proto/chama.proto b/proto/chama.proto
@@ -61,7 +61,7 @@ message UpdateChamaRequest {
 message ChamaUpdates {
   optional string name = 1;
   optional string description = 2;
-  repeated ChamaMember members = 3;
+  repeated ChamaMember add_members = 3;
 }
 
 message FindChamaRequest {