Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks without comments are ignored #4

Closed
mongrelion opened this issue Jun 21, 2016 · 4 comments
Closed

Blocks without comments are ignored #4

mongrelion opened this issue Jun 21, 2016 · 4 comments

Comments

@mongrelion
Copy link
Contributor

I have the following notes file:

# Multiple machines
config.vm.define "foo" do |machine|
end

config.vm.define "bar" do |machine|
end

And when I print it out with notes, it ignores the block that has no precedent comment line (the second ruby block).

Check out the screenshot attached

e42ln

@bittersweet
Copy link
Owner

I'll take a look at the parsing code, newlines in explanations weren't supported yet.

In the meantime you can work around it by removing the newlines, or adding another note in the file ;)

bittersweet added a commit that referenced this issue Jun 21, 2016
@bittersweet
Copy link
Owner

I've pushed some commits for this to https://github.com/bittersweet/notes/tree/support_newlines, please let me know how that works out for you. I've tested it with your example and it looks good, but curious if you have more situations.

@mongrelion
Copy link
Contributor Author

@bittersweet I tried this out and it is working properly 👍
When will you have it merged?

@bittersweet
Copy link
Owner

bittersweet commented Jul 27, 2016

Get it while it's hot https://github.com/bittersweet/notes/releases/tag/v0.7.0

Thanks for the bug report and testing✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants