[PM-18140] Handle unknown SecureNoteTypeJson values

[SaintPatrck]

🎟️ Tracking

PM-18140

📔 Objective

The SecureNoteTypeJson serializer now defaults to GENERIC if an unknown value is received, as GENERIC is the only valid value.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
  issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – f7a8bc3d-dbac-42da-8960-61dba5dd50a0

Great job, no security vulnerabilities found in this Pull Request

[SaintPatrck]

@vvolkgang @fedemkr Thoughts on defaulting this to GENERIC? It's a little heavy handed, but GENERIC is the only known valid note type. This not only fixes deserialization in the client, but it also corrects the record if the user updates the item.

[fedemkr]

In the current state of all clients/server I think it's safe to do so. However, we need to keep this in mind if the SecureNoteType were to add any more values in the future which could break some logic so I'd ask internally if there are any plans on adding more types in the near/mid term future; if not I'd say go for it 😄

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.34%. Comparing base (e929ca8) to head (6e974e4).
Report is 10 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4745   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files         490      490           
  Lines       41323    41323           
  Branches     5880     5880           
=======================================
  Hits        36920    36920           
  Misses       2373     2373           
  Partials     2030     2030           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[SaintPatrck]

Holding for Product review