[PM-14435] Accessibility enabled settings changes to address older and custom Android phone versions #4756
Conversation
…nabledState Checking the Settings.Secure.ENABLED_ACCESSIBILITY_SERVICES when navigating to Autofill settings screen.
|
Great job, no security vulnerabilities found in this Pull Request |
|
Warning @aj-rosado Uploading code coverage report failed. Please check the "Upload to codecov.io" step of Process Test Reports job for more details. |
| LivecycleEventEffect { _, event -> | ||
| when (event) { | ||
| Lifecycle.Event.ON_RESUME -> { | ||
| viewModel.trySendAction(AutoFillAction.LifecycleResume) |
There was a problem hiding this comment.
This should not be bound to a specific screen, can we listen to foreground events in a manager, we already do similar things like this in the AutofillActivityManagerImpl.
There was a problem hiding this comment.
We are updating onForeground, although if an user uses a shortcut to update and doesn't leave the app, in some scenarios we might not have the most recent setting.
also only this screen listens to the stateflow, so I guess updating on this screen is ok
| ) | ||
|
|
||
| init { | ||
| accessibilityManager.addAccessibilityStateChangeListener( |
There was a problem hiding this comment.
Can we just use this callback and instead of using the passed in boolean, use context.isAccessibilityServiceEnabled.
There was a problem hiding this comment.
On contrary to emulator and Android 15, on a xiaomi with android 10 that I've used to test this, this is only triggered when any accessibility is turned on or all turned off.
If there is other accessibility app active (like accessibility menu) and the user activates bitwarden, this listener won't be called.
OnServiceConnected and OnUnbind properly detects AccessibilityService being detected on that device
There was a problem hiding this comment.
Hmmm, are the OnServiceConnected and OnUnbind callbacks enough by themselves or do we still need the onResumed listener?
There was a problem hiding this comment.
it should, but for some reason, they stop listening after some time. When this happens, the accessibility shortcuts also start having an odd behaviour, they always show a dialog turning on the accessibility, never turning accessibility off (usually it works fine turning on and off). Restarting the application doesn't solve this, only reinstalling.
I'm experiencing a similar behaviour (always turning on) on the old MAUI app so I don't believe this is a regression, but MAUI app was showing the correct state when entering the view and the onResume call is to address that
|
Warning @aj-rosado Uploading code coverage report failed. Please check the "Upload to codecov.io" step of Process Test Reports job for more details. |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14435
📔 Objective
Testing on a Xiaomi phone with Android 10 showed some discrepancies to android 15 and emulator versions.
The
AccessibilityManager.isEnabledwas returningtrueif any Accessibility app was turned on.Reading from
Settings.Secure.ENABLED_ACCESSIBILITY_SERVICESand checking is this service exists there addresses this behaviour.AccessibilityStateChangeListeneralso only was called when any of the accessibility apps was turned on or all turned offUpdating the
mutableIsAccessibilityEnabledStateFlowwhenAccessibilityService'sonServiceConnectedandonUnbindkeeps the value correctly updated.In some scenarios, shortcuts get inconsistent and stopped updating correctly the accessibility switch, MAUI app showed a similar behaviour although it always had the correct value when entering the view.
Checking the
Settings.Secure.ENABLED_ACCESSIBILITY_SERVICESwhenonResumemethod is called to ensure it has the most recent setting is always displayed⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes