[PM-4349] Migrate hasPremium and debounceNavigation to be functional #6591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
eliykat
previously approved these changes
Oct 18, 2023
willmartian
previously approved these changes
Oct 31, 2023
…/functional-guards # Conflicts: # .github/whitelist-capital-letters.txt # apps/browser/src/popup/app-routing.module.ts # apps/web/src/app/core/guards/has-premium.guard.ts
eliykat
approved these changes
Dec 5, 2023
willmartian
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Class based router guards are deprecated as of Angular 15.2, per https://angular.io/guide/deprecations#router-class-and-injection-token-guards. To simplify future angular upgrades we need to resolve these deprecations.
This PR migrates the
HasPremiumandDebounceNavigationServiceguards to use the new functional pattern.Before you submit