[PM-5111] Reduce calls to config endpoint #7069
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
We are currently making ~70k calls/minute to the
/config
endpoint. This compares to around ~6k/minute forsync
, for comparison. In testing, I've identified some ways to reduce these calls incrementally.next
ing of theactiveAccount$
observable on account change. ThesetActiveAccount
andaddAccount
were both issuing the change.distinctUntilChanged
to the subscription on theEnvironmentService
, so that if theactiveAccount$
were tonext
the same user ID it will not re-retrieve the environment URLs. The assumption here is that a given user will have the same environment URLs when changing accounts.Code changes
distinctUntilChanged
next
on account changeBefore you submit