generated from ludeeus/integration_blueprint
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an improve_contrast switch #230
Merged
dermotduffy
merged 12 commits into
blakeblackshear:master
from
hawkeye217:improve-contrast
Apr 21, 2022
Merged
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bbacc8c
Add improve_contrast switch
hawkeye217 5d56d7e
Add switch to README
hawkeye217 97231e6
Disable by default and add tests
hawkeye217 81aaff6
Add newline at eof
hawkeye217 71b436b
Add test for disabled improve_contrast switch
hawkeye217 382c63d
Parametrize disabled switch test
hawkeye217 0d31de3
contrast icon
hawkeye217 612cb90
Non-working disabled switch icon test
hawkeye217 a761fbf
Fix test comment
hawkeye217 33f7d36
Keep patch in place
hawkeye217 b549cee
Forgot to pre-commit
hawkeye217 03cf64b
Forgot to pre-commit
hawkeye217 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even better would be to use
@pytest.mark.parametrize
here so that this test gets run for all members ofDISABLED_SWITCH_ENTITY_IDS
(so that when we add more switches there this test will "just work").Take a look at the sensor test for inspiration: https://github.com/blakeblackshear/frigate-hass-integration/blob/master/tests/test_sensor.py#L92
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea. So, something like this? Not sure if I've got the syntax right.
Really appreciate your patience as I learn this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, exactly.
Minor:
disabled_switch_name
asdisabled_entity_id
instead (slightly clearer)str
instead ofAny