Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore attribute labels #506

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Conversation

NickM-27
Copy link
Collaborator

In Frigate 0.13 along with Frigate+ there are certain labels (amazon, face, license_plate, etc.) which are not separately tracked objects and are ONLY attributes of another label (a person has a face, a car has a license plate, etc.)

Given that these labels are not treated as other objects, they will not have their own MQTT snapshots, object counts, etc. so they should be filtered out from the objects that are added.

@dermotduffy dermotduffy added the bug Something isn't working label Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #506 (e5737f3) into dev (c150f9b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev      #506   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1881      1883    +2     
=========================================
+ Hits          1881      1883    +2     
Impacted Files Coverage Δ
custom_components/frigate/__init__.py 100.00% <100.00%> (ø)
custom_components/frigate/const.py 100.00% <100.00%> (ø)

@dermotduffy dermotduffy merged commit bb1bc40 into blakeblackshear:dev Jun 28, 2023
@NickM-27 NickM-27 deleted the ignore-attributes branch August 13, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants