Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove [old] rtmp support #776

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Conversation

dermotduffy
Copy link
Collaborator

  • Requires at least Frigate 0.12 for rtsp support.

@dermotduffy dermotduffy added the bug Something isn't working label Nov 24, 2024
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (946b2f0) to head (60888ed).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #776   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         2023      2014    -9     
=========================================
- Hits          2023      2014    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@dermotduffy
Copy link
Collaborator Author

dermotduffy commented Nov 24, 2024

@felipecrs Mind taking a look at part 2? I set the cutoff to error >= v12, which is when rtmp support was first deprecated (since there was proper streaming!).

@dermotduffy dermotduffy merged commit 6635bf5 into blakeblackshear:master Nov 24, 2024
6 checks passed
@dermotduffy dermotduffy deleted the rtmp branch November 24, 2024 01:08
@@ -174,11 +173,7 @@ def __init__(
# from motion camera entities on selectors
self._attr_device_class = DEVICE_CLASS_CAMERA
self._stream_source = None
self._attr_is_streaming = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be kept as self._cam_name in self._frigate_config.get("go2rtc", {}).get("streams", {}).keys()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants