Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uptime sensor #820

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Add uptime sensor #820

merged 3 commits into from
Jan 6, 2025

Conversation

tpjanssen
Copy link
Contributor

Added uptime sensor

Added uptime sensor
@tpjanssen
Copy link
Contributor Author

@dermotduffy @NickM-27 Not sure why the tests are failing... Is this something I have to fix?

@NickM-27
Copy link
Collaborator

NickM-27 commented Jan 6, 2025

You have to add a test that tests the unhappy path. It is referring to

            except (TypeError, ValueError):
                pass

@NickM-27 NickM-27 self-requested a review January 6, 2025 16:58
@tpjanssen
Copy link
Contributor Author

You have to add a test that tests the unhappy path. It is referring to

            except (TypeError, ValueError):
                pass

Fixed. Thanks for pointing this out.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8affacb) to head (862eada).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #820   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         2140      2173   +33     
=========================================
+ Hits          2140      2173   +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dermotduffy dermotduffy added the enhancement New feature or request label Jan 6, 2025
@dermotduffy dermotduffy changed the title Added uptime sensor Add uptime sensor Jan 6, 2025
@dermotduffy dermotduffy merged commit 09b711c into blakeblackshear:master Jan 6, 2025
6 checks passed
@dermotduffy
Copy link
Collaborator

Thanks @tpjanssen !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants