#20 - Added ability to whitelist base templates

src/Leprechaun.Console/Leprechaun.config

@@ -103,7 +103,9 @@
 		</fieldFilter>
 
 		<typeNameGenerator type="Leprechaun.MetadataGeneration.StandardTypeNameGenerator, Leprechaun" singleInstance="true" namespaceRootPath="/sitecore/templates/$(layer)/$(module)" keepLeadingUnderscores="false" />
-		<templateReader type="Leprechaun.TemplateReaders.DataStoreTemplateReader, Leprechaun" singleInstance="true" />
+		<templateReader type="Leprechaun.TemplateReaders.DataStoreTemplateReader, Leprechaun" singleInstance="true">
+			<excludedBaseTemplate id="{8CA06D6A-B353-44E8-BC31-B528C7306971}" name="Rendering Parameters Template" />
+		</templateReader>
 
 		<!-- This should match up with the Unicorn/Rainbow configuration -->
 		<serializationFormatter type="Rainbow.Storage.Yaml.YamlSerializationFormatter, Rainbow.Storage.Yaml" singleInstance="true">

src/Leprechaun.Tests/TemplateReaders/DataStoreTemplateReaderTests.cs

@@ -51,7 +51,7 @@ public void GetAllFields_Includes_AllFields(TestableDataSourceTemplateReader sut
 
 	public class TestableDataSourceTemplateReader : DataStoreTemplateReader
 	{
-		public TestableDataSourceTemplateReader(IDataStore dataStore) : base(dataStore)
+		public TestableDataSourceTemplateReader(IDataStore dataStore) : base(null, dataStore)
 		{
 		}
 

src/Leprechaun/Extensions/XmlNodeExtensions.cs

@@ -0,0 +1,21 @@
+using System;
+using System.Xml;
+
+namespace Leprechaun.Extensions
+{
+	public static class XmlNodeExtensions
+	{
+		public static string GetExpectedAttribute(this XmlNode node, string attributeName)
+		{
+			if(node == null)
+				throw new ArgumentNullException(nameof(node));
+
+			// ReSharper disable once PossibleNullReferenceException
+			XmlAttribute attribute = node.Attributes[attributeName];
+
+			if (attribute == null) throw new InvalidOperationException($"Missing expected '{attributeName}' attribute on '{node.Name}' node while processing: {node.OuterXml}");
+
+			return attribute.Value;
+		}
+	}
+}

src/Leprechaun/Filters/StandardTemplatePredicate.cs

@@ -3,6 +3,7 @@
 using System.Linq;
 using System.Xml;
 using Configy.Containers;
+using Leprechaun.Extensions;
 using Leprechaun.Filters.Exclusions;
 using Leprechaun.Model;
 using Rainbow.Storage;
@@ -114,7 +115,7 @@ protected virtual void EnsureEntriesExist(string configurationName)
 
 		protected virtual TemplateTreeRoot CreateIncludeEntry(XmlNode configuration)
 		{
-			string path = GetExpectedAttribute(configuration, "path");
+			string path = configuration.GetExpectedAttribute("path");
 
 			// ReSharper disable once PossibleNullReferenceException
 			var name = configuration.Attributes["name"];
@@ -135,13 +136,13 @@ protected virtual IPresetTreeExclusion CreateExcludeEntry(XmlElement excludeNode
 		{
 			if (excludeNode.HasAttribute("path"))
 			{
-				return new PathBasedPresetTreeExclusion(GetExpectedAttribute(excludeNode, "path"), root);
+				return new PathBasedPresetTreeExclusion(excludeNode.GetExpectedAttribute("path"), root);
 			}
 
 			var exclusions = excludeNode.ChildNodes
 				.OfType<XmlElement>()
 				.Where(element => element.Name.Equals("except") && element.HasAttribute("name"))
-				.Select(element => GetExpectedAttribute(element, "name"))
+				.Select(element => element.GetExpectedAttribute("name"))
 				.ToArray();
 
 			if (excludeNode.HasAttribute("children"))
@@ -151,21 +152,12 @@ protected virtual IPresetTreeExclusion CreateExcludeEntry(XmlElement excludeNode
 
 			if (excludeNode.HasAttribute("childrenOfPath"))
 			{
-				return new ChildrenOfPathBasedPresetTreeExclusion(GetExpectedAttribute(excludeNode, "childrenOfPath"), exclusions, root);
+				return new ChildrenOfPathBasedPresetTreeExclusion(excludeNode.GetExpectedAttribute("childrenOfPath"), exclusions, root);
 			}
 
 			throw new InvalidOperationException($"Unable to parse invalid exclusion value: {excludeNode.OuterXml}");
 		}
 
-		protected static string GetExpectedAttribute(XmlNode node, string attributeName)
-		{
-			// ReSharper disable once PossibleNullReferenceException
-			var attribute = node.Attributes[attributeName];
-
-			if (attribute == null) throw new InvalidOperationException($"Missing expected '{attributeName}' attribute on '{node.Name}' node while processing predicate: {node.OuterXml}");
-
-			return attribute.Value;
-		}
 
 		IEnumerable<TreeRoot> ITreeRootFactory.CreateTreeRoots()
 		{

src/Leprechaun/TemplateReaders/DataStoreTemplateReader.cs

@@ -2,6 +2,8 @@
 using System.Collections;
 using System.Collections.Generic;
 using System.Linq;
+using System.Xml;
+using Leprechaun.Extensions;
 using Leprechaun.Model;
 using Rainbow.Model;
 using Rainbow.Storage;
@@ -27,9 +29,32 @@ public class DataStoreTemplateReader : ITemplateReader
 
 		private readonly IDataStore _dataStore;
 
-		public DataStoreTemplateReader(IDataStore dataStore)
+		public DataStoreTemplateReader(XmlNode configNode, IDataStore dataStore)
 		{
 			_dataStore = dataStore;
+			ParseExcludedTemplates(configNode);
+		}
+
+		protected void ParseExcludedTemplates(XmlNode configNode)
+		{
+			IEnumerable<XmlNode> nodes = configNode.ChildNodes
+				.Cast<XmlNode>()
+				.Where(node => node.Name == "excludedBaseTemplate")
+				.ToList();
+
+			foreach (XmlNode excludedTemplate in nodes)
+			{
+				var id = excludedTemplate.GetExpectedAttribute("id");
+				if (Guid.TryParse(id, out Guid templateId))
+				{
+					_ignoredBaseTemplateIds.Add(templateId);
+				}
+				else
+				{
+					throw new InvalidOperationException($"'{id}' is not a valid Guid in '{excludedTemplate.OuterXml}'");
+				}
+			}
+
 		}
 
 		public TemplateInfo[] GetTemplates(params TreeRoot[] rootPaths)
@@ -169,12 +194,15 @@ protected virtual Guid[] ParseMultilistValue(string value)
 				.ToArray();
 		}
 
-		protected virtual ICollection<Guid> IgnoredBaseTemplateIds => new HashSet<Guid>
+		private readonly HashSet<Guid> _ignoredBaseTemplateIds = new HashSet<Guid>
 		{
 			StandardTemplateId,
 			FolderId
 		};
 
+		protected virtual ICollection<Guid> IgnoredBaseTemplateIds => _ignoredBaseTemplateIds;
+
+
 		protected virtual IDictionary<Guid, string> GetAllFields(IItemData item)
 		{
 			var allFields = new Dictionary<Guid, string>();