Updated ReadWriteSpinlock to be atomically upgrade-able from Reader to #129
Conversation
accelerated
force-pushed
the
upgrade-writer
branch
3 times, most recently
from
0037f02 to
43f4958
Compare
accelerated
force-pushed
the
upgrade-writer
branch
2 times, most recently
from
60b389c to
6bc5e26
Compare
accelerated
force-pushed
the
upgrade-writer
branch
2 times, most recently
from
a54bed5 to
e96cf02
Compare
Writer. Signed-off-by: Alexander Damian <[email protected]>
accelerated
force-pushed
the
upgrade-writer
branch
from
e96cf02 to
b2c57b9
Compare
| } | ||
|
|
||
| inline | ||
| bool ReadWriteMutex::ReadGuard::ownsLock() const | ||
| void ReadWriteMutex::Guard::lock() |
There was a problem hiding this comment.
I think we should have a lockRead() and a lockWrite() here.
| ReadWriteMutex& lock) : | ||
| _mutex(&lock), | ||
| _ownsLock(true) | ||
| bool ReadWriteMutex::Guard::tryLock() |
There was a problem hiding this comment.
likewise tryLockRead() & tryLockWrite() instead of lock()
| ReadWriteSpinLock::WriteGuard::WriteGuard(ReadWriteSpinLock& lock) : | ||
| _spinlock(lock), | ||
| _ownsLock(true) | ||
| void ReadWriteSpinLock::Guard::lock() |
There was a problem hiding this comment.
Same comment as on ReadWriteMutex::Guard; we need lockRead() & lockWrite() rather than lock().
quantum/quantum_read_write_mutex.h
Outdated
|
|
||
| class ReadGuard | ||
| class Guard | ||
| { | ||
| public: | ||
| /// @brief Construct this object and lock the passed-in mutex as a reader. |
There was a problem hiding this comment.
Delete 'as a reader' here.
quantum/quantum_read_write_mutex.h
Outdated
| ReadWriteMutex::AdoptLock); | ||
| /// @note Does not block. | ||
| Guard(ReadWriteMutex& lock, | ||
| LockTraits::AdoptLock); | ||
|
|
||
| /// @brief Destroy this object and unlock the underlying mutex if this object owns it. |
There was a problem hiding this comment.
Rephrase this as "unlock the underlying mutex if this object still owns a lock state on it" or something similar. That is, the object doesn't really give up ownership of the Mutex object (unless we implement release() again). It always owns the Mutex, what it may or may not own is the locked state.
quantum/quantum_read_write_mutex.h
Outdated
|
|
||
| /// @brief Releases the write lock on the underlying mutex. | ||
| /// @brief Releases the read lock on the underlying mutex. | ||
| /// @note Also releases ownership of the underlying mutex. |
There was a problem hiding this comment.
This comment isn't quite right (I expect it's replicated on others); see comments above on destructor.
Signed-off-by: Alexander Damian <[email protected]>
accelerated
force-pushed
the
upgrade-writer
branch
from
92bbf98 to
2866a8e
Compare
Description of changes
Updated
ReadWriteSpinlockto be atomically upgrade-able from Reader to Writer.Signed-off-by: Alexander Damian [email protected]