Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error if drain fails #132

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Return error if drain fails #132

merged 1 commit into from
Aug 21, 2020

Conversation

accelerated
Copy link
Contributor

Signed-off-by: Alexander Damian [email protected]

Return true/false to indicate drain status.

Return error if drain fails
af3c4a7 
Signed-off-by: Alexander Damian <[email protected]>
arosenzweig3
arosenzweig3 approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@arosenzweig3 arosenzweig3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@accelerated accelerated merged commit f68cf63 into bloomberg:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arosenzweig3 arosenzweig3 arosenzweig3 approved these changes

@albertdang2 albertdang2 Awaiting requested review from albertdang2

@safaruqi safaruqi Awaiting requested review from safaruqi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@accelerated @arosenzweig3