Can no longer create records with symbol keys #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increases spec compliance of Record.fromEntries Signed-off-by: Ashley Claymore <[email protected]>
acutmore
commented
Jul 18, 2022
| @@ -46,14 +47,17 @@ function createRecordFromObject(value) { | |||
| // sort all property names by the order specified by | |||
| // the argument's OwnPropertyKeys internal slot | |||
| // EnumerableOwnPropertyNames - 7.3.22 | |||
| const properties = Object.entries(value) | |||
There was a problem hiding this comment.
Object.entries skips enumerable symbols, whereas the spec throws for them. The new code more closely follows the spec operations.
| .flatMap(k => { | ||
| const desc = Object.getOwnPropertyDescriptor(value, k); | ||
| if (!desc.enumerable) return []; | ||
| return [[validateKey(k), validateProperty(value[k])]]; |
There was a problem hiding this comment.
fix here: validate and toString the key once
rricard
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Record.fromEntriesby validating the iterator entry by entryTesting performed
Adds unit tests