Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove no tested types for initial commit #14

Merged
merged 7 commits into from
Dec 8, 2023
Merged

Remove no tested types for initial commit #14

merged 7 commits into from
Dec 8, 2023

Conversation

yuuteng
Copy link

@yuuteng yuuteng commented Dec 8, 2023

I talked with the reviewer, and he suggested us to remove no tested types for initial commit

@yuuteng yuuteng mentioned this pull request Dec 8, 2023
Merged
dprophet
dprophet approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@dprophet dprophet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@dprophet dprophet merged commit 118f911 into bloomberg:erik_teng_merge Dec 8, 2023
86 of 92 checks passed
@yuuteng yuuteng mentioned this pull request Dec 11, 2023
Closed
@yuuteng yuuteng deleted the bloomberg-snowflake-remove-types branch December 11, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprophet dprophet dprophet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuuteng @dprophet