Fix brew install #121
Merged
Fix brew install #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marciniwanicki
force-pushed
the
mi/fix-brew-install
branch
2 times, most recently
from
7722386
to
5b17bff
Compare
Codecov ReportBase: 96.69% // Head: 96.69% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
=======================================
Coverage 96.69% 96.69%
=======================================
Files 50 50
Lines 2750 2750
=======================================
Hits 2659 2659
Misses 91 91 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
**Describe your changes** The installation failed to replace the old version of swiftlint, added `--override` flag to force-install. ```sh 2022-12-30T09:14:46.9499920Z [34m==>[0m [1mDownloading from https://pkg-containers.githubusercontent.com/ghcr1/blobs/sha256:73a9664d8a62c7b5d506a70bf100e0289795df04ece6df12f0b77651e497d42b?se=2022-12-30T09%3A20%3A00Z&sig=eOOVCk%2BBABlFuIbX1nOuFTsAzSNk24IGIUg6DiEj9Q4%3D&sp=r&spr=https&sr=b&sv=2019-12-12[0m 2022-12-30T09:14:47.3381330Z [33mWarning:[0m swiftlint 0.50.3 is available and more recent than version 0.49.1. 2022-12-30T09:14:47.3405350Z [34m==>[0m [1mPouring swiftlint--0.49.1.monterey.bottle.tar.gz[0m 2022-12-30T09:14:47.8176640Z [31mError:[0m The `brew link` step did not complete successfully 2022-12-30T09:14:47.8177060Z The formula built, but is not symlinked into /usr/local 2022-12-30T09:14:47.8178750Z Could not symlink bin/swiftlint 2022-12-30T09:14:47.8179080Z Target /usr/local/bin/swiftlint 2022-12-30T09:14:47.8179360Z already exists. You may want to remove it: 2022-12-30T09:14:47.8179810Z rm '/usr/local/bin/swiftlint' 2022-12-30T09:14:47.8179980Z 2022-12-30T09:14:47.8180140Z To force the link and overwrite all conflicting files: 2022-12-30T09:14:47.8180550Z brew link --overwrite swiftlint 2022-12-30T09:14:47.8180980Z 2022-12-30T09:14:47.8181110Z To list all files that would be deleted: 2022-12-30T09:14:47.8181570Z brew link --overwrite --dry-run swiftlint 2022-12-30T09:14:47.8181750Z 2022-12-30T09:14:47.8181890Z Possible conflicting files are: 2022-12-30T09:14:47.8182200Z /usr/local/bin/swiftlint ``` **Testing performed** - Ensure all CI checks pass Signed-off-by: Marcin Iwanicki <[email protected]>
marciniwanicki
force-pushed
the
mi/fix-brew-install
branch
from
5b17bff
to
7512ad5
Compare
kwridan
approved these changes
Dec 30, 2022
There was a problem hiding this comment.
Thanks @marciniwanicki i wonder if it's time to consider Swift Package plugins, seems the homebrew integration is quite fragile 😞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The installation failed to replace the old version of swiftlint, added
--overrideflag to force-install.Testing performed