Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct ComparatorParameters.init's argument label (configuration=> configurations) #71

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

kishikawakatsumi
Copy link
Contributor

Describe your changes

Correct ComparatorParameters.init's argument label (configuration => configurations)

Testing performed

It's just a fix for the documentation. There are no changes to the code.

… => `configurations`)

Correct `ComparatorParameters.init`'s argument label (`configuration` => `configurations`)

Signed-off-by: Kishikawa Katsumi <[email protected]>
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #71 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   96.18%   96.18%           
=======================================
  Files          44       44           
  Lines        1679     1679           
=======================================
  Hits         1615     1615           
  Misses         64       64           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc5794d...190644f. Read the comment docs.

Copy link
Contributor

@marciniwanicki marciniwanicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks a lot @kishikawakatsumi

@marciniwanicki marciniwanicki merged commit bb8e51d into bloomberg:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants