Update version of tools used #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SwiftFormat has been bumped to 0.48.11 - SwiftLint has been bumped to 0.43.1 - Code has been re-formated for compatibility with the latest SwiftFormat - Note a few rules have been disabled to minimize changes (those can be revisted separately if needed) - Added the brew installation script to the Makefile for convenience - it can be run via `make install_tools` Test Plan: - Run `make install_tools` - Verify the installation of tools works - Run `make lint` - Verify the checks pass Signed-off-by: Kassem Wridan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 47 47
Lines 1853 1853
=======================================
Hits 1783 1783
Misses 70 70
Continue to review full report at Codecov.
|
Signed-off-by: Kassem Wridan <[email protected]>
Signed-off-by: Kassem Wridan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #89
Describe your changes
make install_toolsTest Plan
make install_toolsmake lint