Code review #19
Merged
Code review #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many tests were incorrect, as device was frozen on validation screen. This commit also fixes these tests, which now correctly display the "Application is ready" message.
An incorrect comparison was made to check if the beneficiary had to be displayed. This commit fixes that by ensuring the beneficiary is not empty.
In the "finalize" handler, there is no check to ensure all the parameters have been sent to the plugin. A user could then sign incomplete contract data, or uninitialized data could be displyed on the screen. This fix checks if no more data has to be received by the plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.