Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/ldg 428 support new transaction type cip64 #3

Merged
36 commits merged into from
Apr 2, 2024
Merged

Feat/ldg 428 support new transaction type cip64 #3

36 commits merged into from
Apr 2, 2024

Conversation

keiff3r
Copy link

@keiff3r keiff3r commented Mar 22, 2024

No description provided.

keiff3r added 30 commits March 12, 2024 16:09
@keiff3r
test: write test for get address with ethereum derivation path
4a24915
@keiff3r
feat: Add Ethereum paths to Makefile
e657cdf
@keiff3r
chore: generate golden path snapshot for the new test
43f850c
@keiff3r
test: write tests to validate using ethereum derivation path
3ad5c5b
@keiff3r
chore: generate screens to validate tests (for ethereum derivation path)
2afc50f
@keiff3r
fix: Update ETH_PACKED_DERIVATION_PATH in celo_utils.py
7755d03 
changed the format from 5 derivation to 3 derivations
@keiff3r
chore: Update test snapshots for Ethereum path derivation
2ea6740
@keiff3r
refactor: change eth support implementation
8fb5be2
@keiff3r
fix: add eth derivation path to match ci
f4cd02f
@keiff3r
refactor: change implementation of eth support
3fc8b41
@keiff3r
feat: enable optimisation, remove support for eth path
347004e
@keiff3r
feat: add Ethereum path in Makefile
682c7ef
@keiff3r
chore: generate new test snapshots for nanosp, nano X and stax
9d4a256
@keiff3r
fix(celo.c): add multiple breaks to remove a warning
857a4e7
@keiff3r
fix: Update cx_keccak_init calls to cx_keccak_init_no_throw
8d2786e
@keiff3r
fix: Update ticker and feeTicker to const char pointers
2f2f601
@keiff3r
fix: change cx_hash to cx_hash_no_throw
d69cb3b
@keiff3r
fix: change os_perso_derive_node_bip32 calls to os_derive_bip32_no_throw
cd2a5c8
@keiff3r
fix: remove all 'warn_unused_result' warnings
2c3e39a
@keiff3r
fix: change all deprecated functions calls with recommanded functions
c6e7b83
@keiff3r
feat: create structure to add support for EIP159 & CIP64 without brea…
2e805ac 
…king tests
@keiff3r
test: implement test for eip 1559 and generate golden snapshots
a6ef27e
@keiff3r
feat: prevent signing with other chain_ids but Celo's
3ea3b16
@keiff3r
refactor: rename a test and generate screenshots accordingly
1eb83d2
@keiff3r
fix: add case where chainID is null (to pass ci[Clang Static Analyzer]
ed2062f
@keiff3r
fix: add MIN macro to ethUstream.h and change include order in ethUst…
e80516b 
…ream.c
@keiff3r
fix: add return statement to processAccessList and processAndDiscard …
3491b7f 
…functions
@keiff3r
fix(unit_test): Update txType to CELO_LEGACY in unit test
410c076
@keiff3r
chore: Update app_celo.gif files
1352a74
@keiff3r
test: rename file and add test structure for cip64
0666526
@keiff3r keiff3r self-assigned this Mar 22, 2024
@keiff3r keiff3r marked this pull request as ready for review March 28, 2024 16:33
@keiff3r keiff3r requested a review from Z4karia March 28, 2024 16:34
@keiff3r keiff3r closed this pull request by merging all changes into develop in 0479b15 Apr 2, 2024
@keiff3r keiff3r deleted the feat/LDG-428-support-new-transaction-type-cip64 branch August 22, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Z4karia Z4karia Awaiting requested review from Z4karia

Assignees

@keiff3r keiff3r

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@keiff3r