Feat/ldg 679 nano app prepare the codebase for nbgl devices #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Separate the logic from the display - Add the structure for nbgl display - Add some github workflows
- Remove commented-out global UI state variables - Comment out unused UI preprocessing and display functions - Add NBGL menu implementation with app info and settings - Update version references in app configuration handler
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+5
to
+6
| // ux_state_t G_ux; | ||
| // bolos_ux_params_t G_ux_params; |
Check notice
Code scanning / CodeQL
Commented-out code Note
| @@ -19,7 +19,7 @@ | |||
| #include "menu.h" | |||
| #include "apdu_constants.h" | |||
|
|
|||
| unsigned char G_io_seproxyhal_spi_buffer[IO_SEPROXYHAL_BUFFER_SIZE_B]; | |||
| // unsigned char G_io_seproxyhal_spi_buffer[IO_SEPROXYHAL_BUFFER_SIZE_B]; | |||
Check notice
Code scanning / CodeQL
Commented-out code Note
Comment on lines
+167
to
+170
| // // override point, but nothing more to do | ||
| // void io_seproxyhal_display(const bagl_element_t *element) { | ||
| // io_seproxyhal_display_default((bagl_element_t*)element); | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code Note
Comment on lines
+81
to
+95
| // unsigned int ui_prepro(const bagl_element_t *element) { | ||
| // unsigned int display = 1; | ||
| // if (element->component.userid > 0) { | ||
| // display = (ux_step == element->component.userid - 1); | ||
| // if (display) { | ||
| // if (element->component.userid == 1) { | ||
| // UX_CALLBACK_SET_INTERVAL(2000); | ||
| // } | ||
| // else { | ||
| // UX_CALLBACK_SET_INTERVAL(MAX(3000, 1000 + bagl_label_roundtrip_duration_ms(element, 7))); | ||
| // } | ||
| // } | ||
| // } | ||
| // return display; | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code Note
|
|
||
| #include <stdint.h> | ||
| #include <stdbool.h> | ||
|
|
||
| unsigned int ui_prepro(const bagl_element_t *element); | ||
| // unsigned int ui_prepro(const bagl_element_t *element); |
Check notice
Code scanning / CodeQL
Commented-out code Note
- Modify public key tests to use account number instead of derivation path - Switch to Ed25519Slip curve for public key calculation - Update response unpacking to handle 32-byte public keys - Add snapshot images for confirmation tests - Add active test scope markers
- Implement test cases for address retrieval across different wallet types - Add support for non-confirmation and confirmation modes of address retrieval - Create test scenarios for address review acceptance and rejection - Extend command sender and response unpacker to handle address-related operations - Add snapshot images for address confirmation tests
…complete) - Implement test cases for signing transactions and messages - Update transaction and command sender classes to support new signing methods - Add placeholder tests with TODO comments for future implementation - Modify response unpacking and transaction serialization logic - Simplify signing methods with account number and wallet type parameters
…n-rag' into feat/LDG-679--nano-app-prepare-the-codebase-for-nbgl-devices
- Replace deprecated cryptographic functions with their no-throw counterparts - Simplify signature and key generation methods - Remove unnecessary CX_LAST flag in signing functions
- Create docker-compose.yml for Speculos emulator setup - Add gdb.sh script to simplify debugging workflow - Configure container with source, binary, and debug port mappings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.