Test/ldg 662 nano app migrate tests from rust to python rag #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify public key tests to use account number instead of derivation path - Switch to Ed25519Slip curve for public key calculation - Update response unpacking to handle 32-byte public keys - Add snapshot images for confirmation tests - Add active test scope markers
- Implement test cases for address retrieval across different wallet types - Add support for non-confirmation and confirmation modes of address retrieval - Create test scenarios for address review acceptance and rejection - Extend command sender and response unpacker to handle address-related operations - Add snapshot images for address confirmation tests
…complete) - Implement test cases for signing transactions and messages - Update transaction and command sender classes to support new signing methods - Add placeholder tests with TODO comments for future implementation - Modify response unpacking and transaction serialization logic - Simplify signing methods with account number and wallet type parameters
- Refactor test_sign_tx_short_tx to test_sign_tx_transfer - Update transaction signing method to remove account number and wallet type - Add navigation utility function for cross-device screenshot comparison - Update command sender to use new SIGN_TRANSACTION instruction - Add snapshot images for NanoSP and NanoX devices
Minor UI text adjustment in the sign flow to add a period at the end of the "message" text to create a difference between first screen and validation screen
- Update sign_message test with new payload and signature - Modify command sender to simplify message signing method - Add screenshot navigation for cross-device testing - Remove account number and wallet type from signing flow - Add snapshot images for NanoSP and NanoX devices
- Remove TODO comment for raw transaction and signature - Add TODO comment for testing other transaction types
- Delete cflite_cron.yml GitHub workflow for periodic fuzzing - Remove cflite_pr.yml GitHub workflow for PR-based fuzzing - Delete documentation_generation.yml workflow for generating project docs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…cker - Remove trailing commas from Errors enum - Improve code formatting and consistency - Remove TODO comment in response unpacker
| SliceData_t slice; | ||
| SliceData_init(&slice, data, sizeof(bc->public_key_cell_data)); | ||
| SliceData_move_by(&slice, bc->public_key_label_size_bits); | ||
| SliceData_append(&slice, public_key, PUBLIC_KEY_LENGTH * 8, true); | ||
|
|
||
| for (int16_t i = bc->public_key_cell_index; i >= 0; --i) { | ||
| Cell_t* cell = &bc->cells[i]; | ||
| Cell_t *cell = &bc->cells[i]; |
Check notice
Code scanning / CodeQL
Declaration hides variable Note
- Introduce `run_test` function to reduce code duplication - Add new test cases for USDT burn and transaction confirmation - Maintain existing test coverage for transaction signing - Improve test structure and readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.