feat/Ldg 653 implement method create reward vault #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuilaneDen
reviewed
Jan 21, 2025
src/handle_provide_parameter.c
Outdated
| } | ||
| } | ||
|
|
||
| static void handle_create_reward_vault(ethPluginProvideParameter_t *msg, context_t *context) { |
There was a problem hiding this comment.
C'est de la duplication de code, le handle_create_reward_vault et handle_delegate font la même chose. Peut-être, renommé la fonction en handle_beneficiary() et l'utiliser pour les deux méthodes
There was a problem hiding this comment.
@GuilaneDen ça devrait être fix :)
GuilaneDen
previously approved these changes
Jan 21, 2025
Steven2505
dismissed
GuilaneDen’s stale review
The merge-base changed after approval.
GuilaneDen
previously approved these changes
Jan 21, 2025
Steven2505
dismissed
GuilaneDen’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
develop