Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/replatform-app #13

Merged
merged 7 commits into from
Dec 3, 2024
Merged

Feat/replatform-app #13

merged 7 commits into from
Dec 3, 2024

Conversation

n4l5u0r
Copy link

@n4l5u0r n4l5u0r commented Dec 3, 2024

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

Comment on lines +38 to +43
// int base58_encode(const unsigned char *in, size_t length, unsigned char *out, size_t *outlen) {
// size_t i = 0, j;
// size_t startAt, stopAt;
// size_t zeroCount = 0;
// size_t outputSize;
// size_t pageSize = 10;

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Comment on lines +45 to +47
// if (length > MAX_ENC_INPUT_SIZE) {
// return -1;
// }

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Comment on lines +49 to +51
// while ((zeroCount < length) && (in[zeroCount] == 0)) {
// ++zeroCount;
// }

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Comment on lines +53 to +59
// outputSize = (length - zeroCount) * 138 / 100 + 1;
// int spaces = outputSize / pageSize;
// outputSize += spaces;
// if (*outlen < outputSize) {
// *outlen = outputSize;
// return -1;
// }

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Comment on lines +61 to +68
// memset(out, 0, outputSize);
// stopAt = outputSize - 1;
// for (startAt = zeroCount; startAt < length; startAt++) {
// int carry = in[startAt];
// for (j = outputSize - 1; (int) j >= 0; j--) {
// carry += 256 * out[j];
// out[j] = carry % 58;
// carry /= 58;

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
src/common/time.c Dismissed Show dismissed Hide dismissed
UX_FLOW(ux_display_memo, &ux_display_memo_step);

void handleCborStep(void) {
if (ctx->cborLength < 0) {

Check warning

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always false because cborLength >= 0.
Comment on lines +4 to +5
// ux_state_t G_ux;
// bolos_ux_params_t G_ux_params;

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
src/signEncryptedAmountTransfer.c Dismissed Show dismissed Hide dismissed
src/signTransferToPublic.c Dismissed Show dismissed Hide dismissed
@n4l5u0r n4l5u0r requested a review from a team December 3, 2024 16:19
@n4l5u0r
Copy link
Author

n4l5u0r commented Dec 3, 2024

just need to validate to handover the main to everyone

@n4l5u0r n4l5u0r merged commit 8287206 into main Dec 3, 2024
27 of 33 checks passed
@n4l5u0r n4l5u0r deleted the feat/replatform-app branch December 3, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants