LDG-506: Implement verifyAddress method #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uncomment verify_address method in BoilerplateCommandSender - Update P1/P2 parameters to match legacy address verification - Add test_verify_address_confirm_legacy_path_accepted - Add snapshot images for address verification UI flow - Add pytest.mark.active_test_scope decorator for test isolation
* Add support for new derivation path format that includes identity provider * Update verify address command to handle both legacy and new paths (P1=0x00 for legacy, P1=0x01 for new) * Add new constants for updated path derivation (NEW_PURPOSE=44, NEW_COIN_TYPE=919) * Update tests to support new path verification * Refactor key derivation logic to handle both path types * Update documentation to reflect new APDU command format BREAKING CHANGE: The verify address command now requires P1 parameter to specify path type
The TODO comment about BLS address mismatch is no longer relevant and has been removed.
n4l5u0r
previously approved these changes
Dec 4, 2024
n4l5u0r
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.