Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/LDG-599-enable-flex-stax-compilation #19

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix/LDG-599-enable-flex-stax-compilation #19

merged 1 commit into from
Dec 4, 2024

Conversation

n4l5u0r
Copy link

@n4l5u0r n4l5u0r commented Dec 4, 2024

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 4, 2024
View reviewed changes
src/common/ui/display.h
extern const ux_flow_step_t *const ux_display_memo[];
extern const ux_flow_step_t ux_display_memo_step_nocb;

// extern const ux_flow_step_t *const ux_display_memo[];

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
@n4l5u0r n4l5u0r requested a review from keiff3r December 4, 2024 15:38
keiff3r
keiff3r requested changes Dec 4, 2024
View reviewed changes
Copy link

@keiff3r keiff3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment in src/common/ui/display.h

@n4l5u0r n4l5u0r merged commit 7742e95 into main Dec 4, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keiff3r keiff3r keiff3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n4l5u0r @keiff3r